Merged
Conversation
pbrubeck
commented
Aug 21, 2025
Contributor
|
Why does this need a review? And didn't you just change those solver parameters? |
connorjward
previously approved these changes
Aug 21, 2025
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Subject to removing the CI changes. Also please rename the PR to something clearer.
pbrubeck
changed the title
pbrubeck
force-pushed
the
pbrubeck/test/fiat-merge-release
branch
from
90cd9a4 to
27229f4
Compare
pbrubeck
added a commit
that referenced
this pull request
Sep 8, 2025
pbrubeck
added a commit
that referenced
this pull request
Sep 8, 2025
* Test consistent facet orientation for non-point variants * Fix solver parameters for Stokes test (#4514) --------- Co-authored-by: ksagiyam <46749170+ksagiyam@users.noreply.github.com>
connorjward
pushed a commit
that referenced
this pull request
Sep 24, 2025
* Test consistent facet orientation for non-point variants * Fix solver parameters for Stokes test (#4514) --------- Co-authored-by: ksagiyam <46749170+ksagiyam@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There were some redudant flops caused by poor handling of
gem.Deltawhere we were casting it into dense identity matrices in code generated forVectorElement. MUMPS LU seems happy after restoring the original behavior without the dense identity firedrakeproject/fiat#166